netdev - Re: [PATCH] net/core: Save the port number a netdevice uses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100526090850.GB28748@mtldesk030.lab.mtl.com>
Date:	Wed, 26 May 2010 12:08:52 +0300
From:	Eli Cohen <eli@....mellanox.co.il>
To:	David Miller <davem@...emloft.net>
Cc:	eli@...lanox.co.il, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org, rdreier@...co.com,
	yevgenyp@...lanox.co.il
Subject: Re: [PATCH] net/core: Save the port number a netdevice uses

On Wed, May 26, 2010 at 01:55:26AM -0700, David Miller wrote:
> From: Eli Cohen <eli@....mellanox.co.il>
> Date: Wed, 26 May 2010 11:45:23 +0300
> 
> 
> What's wrong with using the existing dev_id sysfs file name and saying
> that it means the port number of the card?
> 
> Nobody, and I really mean nobody, uses this thing any more.
> 
> It used to be a way for devices like the qeth driver to get it's
> IPV6 EUI48 value set properly for local IPV6 addresses assigned
> to the device, but that got fixed in a different way.
> 
> So we can use this value however we wish now, and it defaults to zero
> for every single device now, and is propagated across VLAN devices,
> which is perfect.

OK. So if I understand you correctly, you think that I should not
bother to set a default value of 1. Each driver that cares about the
value of this field, will set it however they want.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html