netdev - Re: [patch] caif: unlock on error path in cfserl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimYIjrnOwzSyALY42fhNojwh1zawaFMUVC1ml6Y@mail.gmail.com>
Date:	Wed, 26 May 2010 20:18:36 +0200
From:	Sjur Brændeland <sjurbren@...il.com>
To:	Dan Carpenter <error27@...il.com>
Cc:	Sjur Braendeland <sjur.brandeland@...ricsson.com>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] caif: unlock on error path in cfserl_receive()

Hi Dan.

Dan Carpenter <error27@...il.com> wrote:
> There was an spin_unlock missing on the error path.  The spin_lock was
> tucked in with the declarations so it was hard to spot.  I added a new
> line.
>
> Signed-off-by: Dan Carpenter <error27@...il.com>
Acked-by: Sjur Braendeland

Well spotted! Thanks for reviewing and fixing this.

Regards
Sjur
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html