[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20100527.161011.104042698.davem@davemloft.net>
Date: Thu, 27 May 2010 16:10:11 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: eric.dumazet@...il.com
Cc: torvalds@...ux-foundation.org, mingo@...e.hu, tglx@...utronix.de,
akpm@...ux-foundation.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: boot crash in arp_error_report()
From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 27 May 2010 22:18:24 +0200
> [PATCH] net: fix __neigh_event_send()
>
> commit 7fee226ad23 (net: add a noref bit on skb dst) missed one spot
> where an skb is enqueued, with a possibly not refcounted dst entry.
>
> __neigh_event_send() inserts skb into arp_queue, so we must make sure
> dst entry is refcounted, or dst entry can be freed by garbage collector
> after caller exits from rcu protected section.
>
> Reported-by: Ingo Molnar <mingo@...e.hu>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
Applied, thanks Eric.
Ingo can we get a confirmation that this fixes the bootup crash?
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists