netdev - Re: [patch 3/3] rds/iw_rdma: remove unneeded kfree()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTilQJJ2k27gwF8VcrUTR3L9JU-7D_hCphEZp4CSy@mail.gmail.com>
Date:	Fri, 28 May 2010 00:38:05 -0700
From:	Andrew Grover <andy.grover@...il.com>
To:	Dan Carpenter <error27@...il.com>
Cc:	Andy Grover <andy.grover@...cle.com>,
	"David S. Miller" <davem@...emloft.net>, rds-devel@....oracle.com,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch 3/3] rds/iw_rdma: remove unneeded kfree()

Thanks Dan, nice catches.

For all three:

Acked-by: Andy Grover <andy.grover@...cle.com>

-- Andy

On Thu, May 27, 2010 at 2:11 AM, Dan Carpenter <error27@...il.com> wrote:
> The "dma_pages" variable is always NULL at this point so the kfree()
> isn't needed.
>
> Signed-off-by: Dan Carpenter <error27@...il.com>
>
> diff --git a/net/rds/iw_rdma.c b/net/rds/iw_rdma.c
> index 48d5073..742ab6a 100644
> --- a/net/rds/iw_rdma.c
> +++ b/net/rds/iw_rdma.c
> @@ -334,7 +334,6 @@ static u64 *rds_iw_map_scatterlist(struct rds_iw_device *rds_iwdev,
>  out_unmap:
>        ib_dma_unmap_sg(rds_iwdev->dev, sg->list, sg->len, DMA_BIDIRECTIONAL);
>        sg->dma_len = 0;
> -       kfree(dma_pages);
>        return ERR_PTR(ret);
>  }
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html