netdev - Re: [PATCH] net/fec: fix pm to survive to suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100529.001534.57459102.davem@davemloft.net>
Date:	Sat, 29 May 2010 00:15:34 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric@...rea.com
Cc:	s.hauer@...gutronix.de, sshtylyov@...sta.com,
	linux-arm-kernel@...ts.infradead.org, fabioestevam@...oo.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net/fec: fix pm to survive to suspend/resume

From: Eric Bénard <eric@...rea.com>
Date: Thu, 27 May 2010 19:53:48 +0200

> * with this patch, if the connection if active before suspend, it
> will be active after resume.
> * before this patch, it was necessary to close the interface and
> reopen it to recover the connection.
> 
> Signed-off-by: Eric Bénard <eric@...rea.com>

On resume the PHY should be reset and the link renegotiated (or set to
a fixed speed/duplex if set by the user via ethtool) just like as
happens on ->open().

You seem to be avoiding that here.

If the PHY is not functioning properly after the ->resume() triggered
reset, fix that instead.

I'm not applying this patch, it doesn't look the right thing to do at
all.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html