netdev - Re: [PATCH] bnx2: Fix IRQ failures during kdump.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C27F8246C663564A84BB7AB3439772421B78147573@IRVEXCHCCR01.corp.ad.broadcom.com>
Date:	Sat, 29 May 2010 09:22:07 -0700
From:	"Michael Chan" <mchan@...adcom.com>
To:	"'David Miller'" <davem@...emloft.net>,
	"grundler@...isc-linux.org" <grundler@...isc-linux.org>
cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: Re: [PATCH] bnx2: Fix IRQ failures during kdump.

David Miller wrote:

>
> The generic PCI layer very well can turn off MSI on all devices
> when it starts up or a device is plugged in.
>
> That's all he is doing.
>
> Drivers essentially expect that the device comes up in INTX mode
> when the driver probes the device.  All his change is doing
> is forcing that to be true, and there is no reason the generic
> PCI code can't do that.
>

I think there may be more issues after thinking about it some more.
The device is essentially still active at this time.  The PCI
layer can turn off certain things, but enabling INTX can lead to
"irq x: nobody cared" if the driver is not ready for it.  The
device really needs to be reset by the driver to be totally
reliable.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html