netdev - Re: [patch] caif: remove unneeded null check in caif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100531.003200.102574775.davem@davemloft.net>
Date:	Mon, 31 May 2010 00:32:00 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sjurbren@...il.com
Cc:	error27@...il.com, sjur.brandeland@...ricsson.com,
	eric.dumazet@...il.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] caif: remove unneeded null check in caif_connect()

From: Sjur Brændeland <sjurbren@...il.com>
Date: Mon, 24 May 2010 21:56:01 +0200

> Dan Carpenter <error27@...il.com> wrote:
>> We already dereferenced uaddr towards the start of the function when we
>> checked that "uaddr->sa_family != AF_CAIF".  Both the check here and the
>> earlier check were added in bece7b2398d0: "caif: Rewritten socket
>> implementation".  Before that patch, we assumed that we recieved a valid
>> pointer for uaddr, and based on that, I have removed this check.
>>
>> Signed-off-by: Dan Carpenter <error27@...il.com>
> Thanks Looks good,
> Acked-by: Sjur Braendeland <sjur.brandeland@...ricsson.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html