netdev - Re: [PATCH] netfilter: xtables: stackptr should be percpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C03C9BD.2080907@trash.net>
Date:	Mon, 31 May 2010 16:37:49 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Jan Engelhardt <jengelh@...ozas.de>
CC:	Eric Dumazet <eric.dumazet@...il.com>,
	Xiaotian Feng <dfeng@...hat.com>,
	netfilter-devel@...r.kernel.org, netfilter@...r.kernel.org,
	coreteam@...filter.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Alexey Dobriyan <adobriyan@...il.com>
Subject: Re: [PATCH] netfilter: xtables: stackptr should be percpu

Jan Engelhardt wrote:
> On Monday 2010-05-31 15:13, Eric Dumazet wrote:
>> All cpus share a single cache line for their 'stackptr' storage,
>> introduced in commit f3c5c1bfd4
>>
>> This is a stable candidate (2.6.34)
> 
> Stackptr was first introduced for 2.6.35-rcX.
> 
>> +	i->stackptr = alloc_percpu(unsigned int);
>> 	if (i->stackptr == NULL)
>> 		return -ENOMEM;
>> -	memset(i->stackptr, 0, size);
>>
>> 	size = sizeof(void **) * nr_cpu_ids;
>> 	if (size > PAGE_SIZE)
> 
> Are alloc_percpu areas cleared?
> 
> Acked-By: Jan Engelhardt <jengelh@...ozas.de>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html