netdev - Re: [PATCH] net/core: Save the port number a netdevice uses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100602.101222.51286679.davem@davemloft.net>
Date:	Wed, 02 Jun 2010 10:12:22 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	eli@....mellanox.co.il, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org, rdreier@...co.com,
	yevgenyp@...lanox.co.il
Subject: Re: [PATCH] net/core: Save the port number a netdevice uses

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Wed, 02 Jun 2010 17:42:29 +0100

> On Wed, 2010-05-26 at 02:16 -0700, David Miller wrote:
>> From: Eli Cohen <eli@....mellanox.co.il>
>> Date: Wed, 26 May 2010 12:08:52 +0300
>> 
>> > So if I understand you correctly, you think that I should not bother
>> > to set a default value of 1. Each driver that cares about the value
>> > of this field, will set it however they want.
>> 
>> I actually mean that the value "0" should mean the first port,
>> the value "1" should mean the second port, etc.
> 
> There's a compatibility problem here though: when user-space looks at
> this number it can't tell whether "0" really means the first port or
> that the driver isn't setting dev_id.

That's perfect, it means we don't have to add explicit settings to
drivers which driver only one port.  Ie. the vast majority of
cases.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html