netdev - Re: [PATCH net-next-2.6] net: replace hooks in __netif_receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100602204345.GE2385@linux.vnet.ibm.com>
Date:	Wed, 2 Jun 2010 13:43:45 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Stephen Hemminger <shemminger@...tta.com>,
	Jiri Pirko <jpirko@...hat.com>, netdev@...r.kernel.org,
	davem@...emloft.net, kaber@...sh.net
Subject: Re: [PATCH net-next-2.6] net: replace hooks in __netif_receive_skb
 V5

On Wed, Jun 02, 2010 at 05:15:22PM +0200, Eric Dumazet wrote:
> Le mercredi 02 juin 2010 à 08:07 -0700, Stephen Hemminger a écrit :
> > On Wed, 2 Jun 2010 09:52:08 +0200
> > Jiri Pirko <jpirko@...hat.com> wrote:
> > 
> > > +
> > > +	err = netdev_rx_handler_register(dev, macvlan_handle_frame);
> > > +	if (err) {
> > > +		rcu_assign_pointer(dev->macvlan_port, NULL);
> > > +		kfree(port);
> > > +	}
> > > +
> > > +	return err;
> > >  }
> > 
> > Rcu assign is not necessary here for because the hook didn't
> > get registered so there is no way for other CPU to see it.
> > 
> 
> Thats a valid point, but we should use it, and not care of this litle
> detail. Compiler generates same code anyway, since NULL value is tested
> by rcu_assign_pointer().
> 
> If we dont use rcu_assign_pointer() ourself, Paul or Arnd will put it
> one day or another :)
> 
> http://lkml.org/lkml/2010/6/1/290

Some year soon, I hope.  ;-)

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html