netdev - Re: [patch] isdn/kcapi: return -EFAULT on copy_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100603.032908.38313177.davem@davemloft.net>
Date:	Thu, 03 Jun 2010 03:29:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jan.kiszka@....de
Cc:	error27@...il.com, isdn@...ux-pingi.de, tilman@...p.cc,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] isdn/kcapi: return -EFAULT on copy_from_user errors

From: Jan Kiszka <jan.kiszka@....de>
Date: Thu, 03 Jun 2010 12:26:42 +0200

> No need to assign retval anymore, it is overwritten in all non-error cases.

I'm still going to apply this fix as-is since it's easier to validate
and provably won't introduce new compiler warnings.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html