lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 3 Jun 2010 19:27:23 +0800
From:	Junchang Wang <junchangwang@...il.com>
To:	romieu@...zoreil.com
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: [Patch 2/2]r8169: remove redundant RTL_W32

Writting "cmd" into "CounterAddrLow" twice is redundant.

Signed-off-by: Junchang Wang <junchangwang@...il.com>
---
 drivers/net/r8169.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 217e709..e0a77a0 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -1207,7 +1207,6 @@ static void rtl8169_update_counters(struct net_device *dev)
 
 	RTL_W32(CounterAddrHigh, (u64)paddr >> 32);
 	cmd = (u64)paddr & DMA_BIT_MASK(32);
-	RTL_W32(CounterAddrLow, cmd);
 	RTL_W32(CounterAddrLow, cmd | CounterDump);
 
 	while (wait--) {
--
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists