netdev - Re: [PATCH] net: check for refcount if pop a stacked dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100604112346.GC13408@secunet.com>
Date:	Fri, 4 Jun 2010 13:23:46 +0200
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: check for refcount if pop a stacked dst_entry

On Fri, Jun 04, 2010 at 12:51:19PM +0200, Eric Dumazet wrote:
> 
> Hmm, this might fix the thing, but we probably can do it without the
> dst_clone(), if you replace the 
> 
> skb_dst_set(skb, dst);
> 
> by 
> 
> skb_dst_set_noref(skb, dst);
> 
> in xfrm_output_one() ?
> 

Yes, this should work too. I'll update the patch to use
skb_dst_set_noref() in xfrm_output_one() and remove the 
dst_clone() in skb_dst_pop().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html