netdev - Re: [PATCH net-next-2.6] ipv4: avoid two atomic ops in ip_rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100607.215119.176661892.davem@davemloft.net>
Date:	Mon, 07 Jun 2010 21:51:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] ipv4: avoid two atomic ops in
 ip_rt_redirect()

From: David Miller <davem@...emloft.net>
Date: Mon, 07 Jun 2010 21:26:22 -0700 (PDT)

> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Mon, 07 Jun 2010 15:23:03 +0200
> 
>> in_dev_get() -> __in_dev_get_rcu() in a rcu protected function.
>> 
>> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> 
> Applied.

I needed to modify this patch to get it to build.

You left a code label with no code afterwards at the end of
ip_rt_redirect() when CONFIG_IP_ROUTE_VERBOSE is disabled,
which breaks the build.

I fixed it by adding a semicolon.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html