netdev - RE: [PATCH 11/12] sfc: Only count bad packets in rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1276020571.2185.52.camel@achroite.uk.solarflarecom.com>
Date:	Tue, 08 Jun 2010 19:09:31 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Dmitry Kravkov <dmitry@...adcom.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH 11/12] sfc: Only count bad packets in rx_errors

On Tue, 2010-06-08 at 02:20 -0700, Dmitry Kravkov wrote:
> Hi,
> 
> Different drivers include different errors in stats->rx_errors:

Your table didn't line up when display here.  It appears you used
6-space tabs so I've expanded them to spaces on that assumption:

>   bxn2        bnx2x       ixgbx       sfc         dnet        atlx
> ----------------------------------------------------------------------
> rx_length   rx_length   rx_length   rx_length   rx_length   rx_length
> rx_over     rx_over                                         rx_over
> rx_frame    rx_frame                rx_frame    rx_frame    rx_frame
> rx_crc      rx_crc      rx_crc      rx_crc                  rx_crc
>             rx_fifo                                         rx_fifo
>             rx_missed                                       rx_missed
>                                     rx_symbol
>                                                 unsup_opcd
> ----------------------------------------------------------------------
> Is there any documentation which defines what should this statistic include?

My references are the comments on the structure (in <linux/if_link.h>
and <linux/netdevice.h>) and an email by Donald Becker
<http://www.uwsg.iu.edu/hypermail/linux/net/0003.3/0154.html>.  The
comments could probably be expanded.

Note also that some of the statistics are combined as follows in
/proc/net/dev, which is what ifconfig uses:

Heading/subheading  Summed statistics
-----------------------------------------------------------------------------------------------
Receive/drop        rx_dropped, rx_missed_errors
Receive/frame       rx_length_errors, rx_over_errors, rx_crc_errors, rx_frame_errors
Transmit/carrier    tx_carrier_errors, tx_aborted_errors, tx_window_errors, tx_heartbeat_errors

Something that doesn't make sense to me is that rx_over_errors is
included under 'frame' rather than under 'drop'.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html