netdev - Re: [PATCH net-next-2.6] phonet: use call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100609.161507.226788333.davem@davemloft.net>
Date:	Wed, 09 Jun 2010 16:15:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	remi@...lab.net, jpirko@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] phonet: use call_rcu for phonet device
 free

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 07 Jun 2010 15:49:43 +0200

> Le lundi 07 juin 2010 à 15:43 +0200, Rémi Denis-Courmont a écrit :
>> On Mon, 7 Jun 2010 15:27:39 +0200, Jiri Pirko <jpirko@...hat.com> wrote:
>> > Use call_rcu rather than synchronize_rcu.
>> > 
>> > Signed-off-by: Jiri Pirko <jpirko@...hat.com>
>> 
>> This looks fine to me, but what is the goal here? The RCU documentation
>> seems to imply that synchronize_rcu() is preferable over call_rcu() when at
>> all possible.
>> 
> 
> Thats not exactly that.
> 
> synchronize_rcu() is easier, in respect of memory use.
> But its drawback is current thread is blocked for several milli seconds.
> 
> In the end, call_rcu() is more scalable.
> 
> Acked-by: Eric Dumazet <eric.dumazet@...il.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html