netdev - Re: [PATCH] gianfar: Revive the driver for eTSEC devices (disable timestamping)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100609.162725.189714554.davem@davemloft.net>
Date:	Wed, 09 Jun 2010 16:27:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	avorontsov@...sta.com
Cc:	Manfred.Rudigier@...cron.at, netdev@...r.kernel.org,
	linuxppc-dev@...abs.org
Subject: Re: [PATCH] gianfar: Revive the driver for eTSEC devices (disable
 timestamping)

From: Anton Vorontsov <avorontsov@...sta.com>
Date: Wed, 9 Jun 2010 23:32:19 +0400

> Since commit cc772ab7cdcaa24d1fae332d92a1602788644f7a ("gianfar: Add
> hardware RX timestamping support"), the driver no longer works on
> at least MPC8313ERDB and MPC8568EMDS boards (and possibly much more
> boards as well).
> 
> That's how MPC8313 Reference Manual describes RCTRL_TS_ENABLE bit:
> 
>   Timestamp incoming packets as padding bytes. PAL field is set
>   to 8 if the PAL field is programmed to less than 8. Must be set
>   to zero if TMR_CTRL[TE]=0.
> 
> I see that the commit above sets this bit, but it doesn't handle
> TMR_CTRL. Manfred probably had this bit set by the firmware for
> his boards. But obviously this isn't true for all boards in the
> wild.
> 
> Also, I recall that Freescale BSPs were explicitly disabling the
> timestamping because of a performance drop.
> 
> For now, the best way to deal with this is just disable the
> timestamping, and later we can discuss proper device tree bindings
> and implement enabling this feature via some property.
> 
> Signed-off-by: Anton Vorontsov <avorontsov@...sta.com>

Agreed, applied, thanks Anton.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html