[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <874ohc65es.fsf@basil.nowhere.org>
Date: Wed, 09 Jun 2010 09:17:47 +0200
From: Andi Kleen <andi@...stfloor.org>
To: David VomLehn <dvomlehn@...co.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH][RFC] Infrastructure for compact call location representation
David VomLehn <dvomlehn@...co.com> writes:
First your mailer generates broken cc addresses like
"netdev@...r.kernel.org"@cisco.com
> This patch allows the location of a call to be recorded as a small integer,
> with each call location ("callsite") assigned a new value the first time
> the code in that location is executed. Locations can be recorded as a
> an address or as a __FILE__/__LINE__ pair. The later is easier to read, but
> requires significantly more space.
Seems overly complicated.
How about using a hash of __FILE__, __LINE__ instead?
With some care you can write it in a way that it gets completely
evaluated by gcc at compile time, so it's just a constant then.
That may use a few more bits then, but that's far better
than having so much runtime overhead for this.
-Andi
--
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists