netdev - Re: [PATCH] gianfar: Revive the driver for eTSEC devices (disable timestamping)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100610102226.GA10653@riccoc20.at.omicron.at>
Date:	Thu, 10 Jun 2010 12:22:26 +0200
From:	Richard Cochran <richardcochran@...il.com>
To:	Anton Vorontsov <cbouatmailru@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Manfred Rudigier <Manfred.Rudigier@...cron.at>,
	netdev@...r.kernel.org, linuxppc-dev@...abs.org
Subject: Re: [PATCH] gianfar: Revive the driver for eTSEC devices (disable
 timestamping)

On Thu, Jun 10, 2010 at 01:31:59PM +0400, Anton Vorontsov wrote:
> > No, we did not set TMR_CTRL[TE].
> 
> So, you deliberately violate the spec and expect it to work
> everywhere? :-)

Sometimes one must read the manual with a grain of salt ;)

> > > Also, I recall that Freescale BSPs were explicitly disabling the
> > > timestamping because of a performance drop.
> > 
> > The BSPs that we have, for the MPC8313ERDB and the P2020RBD both
> > include a (hacky) PTP timestmaping driver. Can you be more specific
> > about where and when Freescale is disabling timestamping?
> 
> Well, bitshrine site no longer allows[1] to list patches at
> http://www.bitshrine.org/gpp/ , but there was a patch for sure.
> 
> I'll try to find it in a bunch of .iso files that I have on disk
> tho.

Thanks, that will help to track the problem down.

> U-Boot 1.1.6 (Oct  9 2007 - 20:42:39) MPC83XX
...
> CPU: MPC8313E, Rev: 10 at 333.333 MHz

We have a newer CPU revision:

   U-Boot 1.3.0 (Dec 23 2008 - 13:38:14) MPC83XX
   CPU:   e300c3, MPC8313E, Rev: 21 at 333.333 MHz, CSB:  166 MHz

Perhaps a bug was fixed between revision 10 and 21...

You mentioned having trouble on the MPC8568EMDS. Was it the same
problem?

Thanks,
Richard


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html