netdev - Re: [PATCH v3] netfilter: Xtables: idletimer target implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.01.1006101752280.15005@obet.zrqbmnf.qr>
Date:	Thu, 10 Jun 2010 17:55:19 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...ozas.de>
To:	Luciano Coelho <luciano.coelho@...ia.com>
cc:	ext Patrick McHardy <kaber@...sh.net>,
	"netfilter-devel@...r.kernel.org" <netfilter-devel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Timo Teras <timo.teras@....fi>
Subject: Re: [PATCH v3] netfilter: Xtables: idletimer target implementation


On Thursday 2010-06-10 15:32, Luciano Coelho wrote:
>
>> I also agree that it makes more sense to lookup and store the timer in
>> the targe.
>
>One quick question about this: did you mean to put it in the target info
>structure, in this case struct idletimer_tg_info? So is it okay to have
>internal data in this structure even though it is mostly for passing
>data from the userspace to the kernel?

You put a kernel-private pointer inside idletimer_tginfo,
similar to what other modules do.
That would also allow you to get a reference to the timer
so that you do not have to call find_by_label on every
idletimer_target invocation.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html