netdev - Re: [PATCH -next] enic: fix pci_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100612.152446.173856802.davem@davemloft.net>
Date:	Sat, 12 Jun 2010 15:24:46 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	scofeldm@...co.com
Cc:	randy.dunlap@...cle.com, netdev@...r.kernel.org,
	vkolluri@...co.com, roprabhu@...co.co
Subject: Re: [PATCH -next] enic: fix pci_alloc_consistent argument

From: Scott Feldman <scofeldm@...co.com>
Date: Tue, 08 Jun 2010 14:55:27 -0700

> On 6/8/10 10:00 AM, "Randy Dunlap" <randy.dunlap@...cle.com> wrote:
> 
>> From: Randy Dunlap <randy.dunlap@...cle.com>
>> 
>> Fix build warning on i386 (32-bit) with 32-bit dma_addr_t:
>> 
>> drivers/net/enic/vnic_dev.c: In function 'vnic_dev_init_prov':
>> drivers/net/enic/vnic_dev.c:716: warning: passing argument 3 of
>> 'pci_alloc_consistent' from incompatible pointer type
>> include/asm-generic/pci-dma-compat.h:16: note: expected 'dma_addr_t *' but
>> argument is of type 'u64 *'
>> 
>> Now builds without warnings on i386 and on x86_64.
>> 
>> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
>> Cc: Scott Feldman <scofeldm@...co.com>
>> Cc: Vasanthy Kolluri <vkolluri@...co.com>
>> Cc: Roopa Prabhu <roprabhu@...co.com>
>> ---
>>  drivers/net/enic/vnic_dev.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Acked-by: Scott Feldman <scofeldm@...co.com>

I'm applying this to net-2.6 since it's also a bug fix, as
passing a u64 pointer in here will make pci_alloc_consistent()
write garbage since it expects a dma_addr_t there which as
on i386 could be 32-bit.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html