netdev - Re: [net-next PATCH] bnx2x: Fix link problem with some DACs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C154D5B.8000004@ans.pl>
Date:	Sun, 13 Jun 2010 23:27:55 +0200
From:	Krzysztof Olędzki <ole@....pl>
To:	Yaniv Rosner <yanivr@...adcom.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [net-next PATCH] bnx2x: Fix link problem with some DACs

On 2010-06-13 13:43, Yaniv Rosner wrote:
> Change 2wire transfer rate of SFP+ module EEPROM from 400Khz to 100Khz since some DACs(direct attached cables) do not work at 400Khz.
>
> Reported-by: Krzysztof Oldzki <ole@....pl>
> Signed-off-by: Yaniv Rosner <yanivr@...adcom.com>
> Signed-off-by: Eilon Greenstein <eilong@...adcom.com>
> ---
> diff --git a/drivers/net/bnx2x_link.c b/drivers/net/bnx2x_link.c
> index a22a7e0..9b15b64 100644
> --- a/drivers/net/bnx2x_link.c
> +++ b/drivers/net/bnx2x_link.c
> @@ -4274,7 +4274,7 @@ static u8 bnx2x_ext_phy_init(struct link_params *params, struct link_vars *vars)
>   				       ext_phy_addr,
>   				       MDIO_PMA_DEVAD,
>   				       MDIO_PMA_REG_8727_TWO_WIRE_SLAVE_ADDR,
> -				       0xa001);
> +				       0xa101);
>
>   			/* Set TX PreEmphasis if needed */
>   			if ((params->feature_config_flags&

Tested-by: Krzysztof Piotr Oledzki <ole@....pl>

However, I believe the comment before this code should also be changed, 
because it is now: "Set 2-wire transfer rate to 400Khz since 100Khz
is not operational ".

Thanks.

Best regards,

			Krzysztof Olędzki
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html