netdev - Re: [net-next PATCH] bnx2x: Fix link problem with some DACs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100614084956.GC25374@verge.net.au>
Date:	Mon, 14 Jun 2010 17:49:56 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Yaniv Rosner <yanivr@...adcom.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [net-next PATCH] bnx2x: Fix link problem with some DACs

On Mon, Jun 14, 2010 at 01:26:28PM +0300, Yaniv Rosner wrote:
> Change 2wire transfer rate of SFP+ module EEPROM from 400Khz to 100Khz since some DACs(direct attached cables) do not work at 400Khz.
> 
> Reported-by: Krzysztof Oldzki <ole@....pl>
> Signed-off-by: Yaniv Rosner <yanivr@...adcom.com>
> Signed-off-by: Eilon Greenstein <eilong@...adcom.com>
> ---
> diff --git a/drivers/net/bnx2x_link.c b/drivers/net/bnx2x_link.c
> index ff70be8..600bc44 100644
> --- a/drivers/net/bnx2x_link.c
> +++ b/drivers/net/bnx2x_link.c
> @@ -4266,14 +4266,15 @@ static u8 bnx2x_ext_phy_init(struct link_params *params, struct link_vars *vars)
>  					       MDIO_PMA_REG_10G_CTRL2, 0x0008);
>  			}
>  
> -			/* Set 2-wire transfer rate to 400Khz since 100Khz
> -			is not operational */

Doesn't the above comment indicate there is some HW where 100Khz doesn't work?

> +			/* Set 2-wire transfer rate of SFP+ module EEPROM
> +			to 100Khz since some DACs(direct attached cables) do
> +			not work at 400Khz.*/
>  			bnx2x_cl45_write(bp, params->port,
>  				       ext_phy_type,
>  				       ext_phy_addr,
>  				       MDIO_PMA_DEVAD,
>  				       MDIO_PMA_REG_8727_TWO_WIRE_SLAVE_ADDR,
> -				       0xa101);
> +				       0xa001);
>  
>  			/* Set TX PreEmphasis if needed */
>  			if ((params->feature_config_flags &
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html