[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1276534945.2074.11.camel@achroite.uk.solarflarecom.com>
Date: Mon, 14 Jun 2010 18:02:25 +0100
From: Ben Hutchings <bhutchings@...arflare.com>
To: Pedro Garcia <pedro.netdev@...devamos.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH] vlan_dev: VLAN 0 should be treated as "no vlan tag"
(802.1p packet)
On Mon, 2010-06-14 at 18:49 +0200, Pedro Garcia wrote:
> On Sun, 13 Jun 2010 22:56:30 +0100, Ben Hutchings
> <bhutchings@...arflare.com> wrote:
> > I have no particular opinion on this change, but you need to read and
> > follow Documentation/SubmittingPatches.
> >
> > Ben.
>
> Sorry, first kernel patch, and I did not know about it. I resubmit with
> the correct style / format:
[...]
Sorry, no you haven't.
- Networking changes go through David Miller's net-next-2.6 tree so you
need to use that as the baseline, not 2.6.26
- Patches should be applicable with -p1, not -p0 (so if you use diff,
you should run it from one directory level up)
- The patch was word-wrapped
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists