netdev - Re: [PATCH net-next-2.6 3/3] bridge: use rx_handler_data pointer to store net_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100615093035.6f54c085@nehalam>
Date:	Tue, 15 Jun 2010 09:30:35 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Jiri Pirko <jpirko@...hat.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, kaber@...sh.net,
	eric.dumazet@...il.com
Subject: Re: [PATCH net-next-2.6 3/3] bridge: use rx_handler_data pointer to
 store net_bridge_port pointer V2

On Tue, 15 Jun 2010 15:28:34 +0200
Jiri Pirko <jpirko@...hat.com> wrote:

> diff --git a/drivers/net/ksz884x.c b/drivers/net/ksz884x.c
> index 7805bbf..e7f4703 100644
> --- a/drivers/net/ksz884x.c
> +++ b/drivers/net/ksz884x.c
> @@ -5718,7 +5718,7 @@ static void dev_set_promiscuous(struct net_device *dev, struct dev_priv *priv,
>  		 * from the bridge.
>  		 */
>  		if ((hw->features & STP_SUPPORT) && !promiscuous &&
> -				dev->br_port) {
> +		    dev->priv_flags & IFF_BRIDGE_PORT) {

I like this patch except for one thing. The mask here should be surrounded
by paren's to avoid the possible confusion about && and & in same if
statement.  The C precedence rules allow this but humans get confused.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html