netdev - Re: [PATCH net-next-2.6] inetpeer: various changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100614.231331.112591806.davem@davemloft.net>
Date:	Mon, 14 Jun 2010 23:13:31 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] inetpeer: various changes

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 15 Jun 2010 07:35:21 +0200

> Try to reduce cache line contentions in peer management, to reduce IP
> defragmentation overhead.
> 
> - peer_fake_node is marked 'const' to make sure its not modified.
>   (tested with CONFIG_DEBUG_RODATA=y)
> 
> - Group variables in two structures to reduce number of dirtied cache
> lines. One named "peers" for avl tree root, its number of entries, and
> associated lock. (candidate for RCU conversion)
> 
> - A second one named "unused_peers" for unused list and its lock 
> 
> - Add a !list_empty() test in unlink_from_unused() to avoid taking lock
> when entry is not unused.
> 
> - Use atomic_dec_and_lock() in inet_putpeer() to avoid taking lock in
> some cases.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html