netdev - Re: [PATCH 2/2] pktgen: receive packets and process incoming rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100615.145948.68117816.davem@davemloft.net>
Date:	Tue, 15 Jun 2010 14:59:48 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	daniel.turull@...il.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org, robert@...julf.net,
	jens.laas@....uu.se, voravit@....se
Subject: Re: [PATCH 2/2] pktgen: receive packets and process incoming rate

From: Daniel Turull <daniel.turull@...il.com>
Date: Thu, 10 Jun 2010 16:05:11 +0200

> This patch adds receiver part to pktgen taking advantages of SMP systems
> with multiple rx queues:
> - Creation of new proc file  /proc/net/pktgen/pgrx to control and display the receiver.
> - It uses PER-CPU variable to store the results per each CPU.
> - Results displayed per CPU and aggregated.
> - The packet handler is add in the protocols handlers (dev_add_pack())
> - Available statistics: packets and bytes received, work time and rate
> - Only process pktgen packets
> - It is possible to select the incoming interface 
> - Documentation updated with the new commands to control the receiver part.
> 
> Signed-off-by: Daniel Turull <daniel.turull@...il.com>

I completely disagree with this patch on two levels:

1) pktgen is for "generating" packets, not receiving them.
   Trying to put lipstick on a pig is never a good idea.

2) The information it gathers and shows is completely useless.
   What's interesting as "RX work cost" is what happens deep
   down in the netif_receive_skb() code paths, IP input, routing,
   netfilter, whatever... but that is not what this thing is
   measuring at all.

Sorry, I'm not applying this.  You can probably do something more
clever with tracepoints.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html