netdev - Re: [v2 Patch 2/2] mlx4: add dynamic LRO disable support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100615121414.26056d15@dhcp-lab-109.englab.brq.redhat.com>
Date:	Tue, 15 Jun 2010 12:14:14 +0200
From:	Stanislaw Gruszka <sgruszka@...hat.com>
To:	Cong Wang <amwang@...hat.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	nhorman@...hat.com, herbert.xu@...hat.com,
	bhutchings@...arflare.com, Ramkrishna.Vepa@...r.com
Subject: Re: [v2 Patch 2/2] mlx4: add dynamic LRO disable support

On Tue, 15 Jun 2010 16:35:35 +0800
Cong Wang <amwang@...hat.com> wrote:
> > BTW: seems default ethtool_op_set_flags introduce a bug on many
> > devices regarding ETH_FLAG_RXHASH. I think default should
> > be EOPNOTSUPP, and these few devices that actually support RXHASH
> > should have custom ethtool_ops->set_flags
> 
> Hmm, you mean this?
> 
>   if (data & ETH_FLAG_RXHASH)
> +    if (!ops->set_flags)
> +        return -EOPNOTSUPP;
> ....

Not really, but I do not have good idea how patch with fix should
looks.

I dislike fact that we setup ->feature that are not in real supported by
particular device instead of returning EOPNOTSUPP. This actually include
both flags NETIF_F_LRO and NETIF_F_RXHASH. 

Perhaps ethtool_op_set_flags should be removed and drivers should use
only custom version. In particular seems e1000e and sfc use this
function improperly and should have NULL as .set_flags.

I will think more about that and maybe cook some patches.

Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html