netdev - Re: [PATCH v5] netfilter: Xtables: idletimer target implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C1769F1.40506@trash.net>
Date:	Tue, 15 Jun 2010 13:54:25 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Luciano Coelho <luciano.coelho@...ia.com>
CC:	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
	jengelh@...ozas.de, Timo Teras <timo.teras@....fi>
Subject: Re: [PATCH v5] netfilter: Xtables: idletimer target implementation

Two final comments:

Luciano Coelho wrote:
> diff --git a/include/linux/netfilter/xt_IDLETIMER.h b/include/linux/netfilter/xt_IDLETIMER.h
> new file mode 100644
> index 0000000..3e1aa1b
> --- /dev/null
> +++ b/include/linux/netfilter/xt_IDLETIMER.h

This file needs to be added to Kbuild to make sure it gets installed
during "make headers_install".

> +static void idletimer_tg_destroy(const struct xt_tgdtor_param *par)
> +{
> +	const struct idletimer_tg_info *info = par->targinfo;
> +
> +	pr_debug("destroy targinfo %s\n", info->label);
> +
> +	mutex_lock(&list_mutex);
> +	if (!info->timer) {
>   

This doesn't seem to be possible.

> +		mutex_unlock(&list_mutex);
> +		return;
> +	}
> +
> +	if (--info->timer->refcnt == 0) {
> +		pr_debug("deleting timer %s\n", info->label);
> +
> +		list_del(&info->timer->entry);
> +		del_timer_sync(&info->timer->timer);
> +		sysfs_remove_file(idletimer_tg_kobj, &info->timer->attr.attr);
> +		kfree(info->timer->attr.attr.name);
> +		kfree(info->timer);
> +	} else {
> +		pr_debug("decreased refcnt of timer %s to %u\n",
> +			 info->label, info->timer->refcnt);
> +	}
> +
> +	mutex_unlock(&list_mutex);
> +}

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html