netdev - Re: [0/8] netpoll/bridge fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1276657400.19249.53.camel@edumazet-laptop>
Date:	Wed, 16 Jun 2010 05:03:20 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	herbert@...dor.apana.org.au, shemminger@...tta.com, mst@...hat.com,
	frzhang@...hat.com, netdev@...r.kernel.org, amwang@...hat.com,
	mpm@...enic.com
Subject: Re: [0/8] netpoll/bridge fixes

Le mercredi 16 juin 2010 à 04:59 +0200, Eric Dumazet a écrit :
> Le mardi 15 juin 2010 à 11:39 -0700, David Miller a écrit :
> > From: Herbert Xu <herbert@...dor.apana.org.au>
> > Date: Fri, 11 Jun 2010 12:11:42 +1000
> > 
> > > On Fri, Jun 11, 2010 at 08:48:39AM +1000, Herbert Xu wrote:
> > >> On Thu, Jun 10, 2010 at 02:59:15PM -0700, Stephen Hemminger wrote:
> > >> >
> > >> > Okay, then add a comment where in_irq is used?
> > >> 
> > >> Actually let me put it into a wrapper.  I'll respin the patches.
> > > 
> > > OK here is a repost.  And this time it really is 8 patches :)
> > > I've tested it lightly.
> > 
> > All applied to net-next-2.6, thanks Herbert.
> 

For this second splat, I dont know yet how to fix it, its 5 in the
morning here, I need a sleep ;)

At this point, no rcu_lock is held.

I wonder how these patches were tested, Herbert ?

[   74.431712] 
[   74.431713] ===================================================
[   74.431717] [ INFO: suspicious rcu_dereference_check() usage. ]
[   74.431719] ---------------------------------------------------
[   74.431722] include/linux/netpoll.h:85 invoked rcu_dereference_check() without protection!
[   74.431725] 
[   74.431726] other info that might help us debug this:
[   74.431727] 
[   74.431730] 
[   74.431730] rcu_scheduler_active = 1, debug_locks = 1
[   74.431733] no locks held by swapper/0.
[   74.431735] 
[   74.431736] stack backtrace:
[   74.431739] Pid: 0, comm: swapper Not tainted 2.6.35-rc1-00508-gdbe3a24-dirty #78
[   74.431742] Call Trace:
[   74.431748]  [<c132cf0c>] ? printk+0xf/0x13
[   74.431754]  [<c1059ac6>] lockdep_rcu_dereference+0x74/0x7d
[   74.431759]  [<c1297628>] __napi_gro_receive+0x4d/0xf6
[   74.431764]  [<c12977a3>] napi_gro_receive+0x19/0x24
[   74.431775]  [<f805d83f>] bnx2x_rx_int+0x101b/0x124e [bnx2x]
[   74.431781]  [<c1050ffc>] ? async_thread+0x198/0x1de
[   74.431787]  [<c129580f>] ? net_tx_action+0x9a/0x12a
[   74.431797]  [<f805f267>] bnx2x_poll+0x5d/0x18b [bnx2x]
[   74.431801]  [<c1297360>] ? net_rx_action+0x1e4/0x21a
[   74.431805]  [<c105ccb2>] ? trace_hardirqs_on_caller+0xe2/0x11c
[   74.431810]  [<c1297218>] net_rx_action+0x9c/0x21a
[   74.431814]  [<c1039a21>] __do_softirq+0x126/0x277
[   74.431819]  [<c10398fb>] ? __do_softirq+0x0/0x277
[   74.431821]  <IRQ>  [<c1039c0d>] ? irq_exit+0x38/0x74
[   74.431828]  [<c1003d1f>] ? do_IRQ+0x87/0x9b
[   74.431833]  [<c1002d2e>] ? common_interrupt+0x2e/0x34
[   74.431838]  [<c105007b>] ? sched_clock_local+0x3f/0x11f
[   74.431843]  [<c11ba45b>] ? acpi_idle_enter_bm+0x271/0x2a0
[   74.431848]  [<c12797bd>] ? cpuidle_idle_call+0x76/0x151
[   74.431852]  [<c1001565>] ? cpu_idle+0x49/0x76
[   74.431857]  [<c1319ece>] ? rest_init+0xd6/0xdb
[   74.431861]  [<c156579f>] ? start_kernel+0x31b/0x320
[   74.431865]  [<c15650c9>] ? i386_start_kernel+0xc9/0xd0



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html