netdev - Re: patch "net: deliver skbs on inactive slaves to exact matches" stalls nfs mounts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C1951F1.9010004@intel.com>
Date:	Wed, 16 Jun 2010 15:36:33 -0700
From:	John Fastabend <john.r.fastabend@...el.com>
To:	Fred Isaman <iisaman@...app.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	NFS list <linux-nfs@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: patch "net: deliver skbs on inactive slaves to exact matches"
 stalls 	nfs mounts

Fred Isaman wrote:
> I am using vmware fusion 3.1.0 on a macbook pro host with a fedora 12
> guest running a 2.6.35-rc3 based kernel,  Upgrading from rc2 to rc3
> introduced a long delay when the guest attempts an nfs mount (~120
> secs).  Reverting patch 597a264b1a9c7e36d1728f677c66c5c1f7e3b837
> "net: deliver skbs on inactive slaves to exact matches" changes back
> to normal behavior.
> 
> Fred

This should be fixed here,

 From e897082fe7a5b591dc4dd5599ac39081a7c8e482 Mon Sep 17 00:00:00 2001
From: John Fastabend <john.r.fastabend@...el.com>
Date: Sun, 13 Jun 2010 10:36:30 +0000
Subject: [PATCH] net: fix deliver_no_wcard regression on loopback device

deliver_no_wcard is not being set in skb_copy_header.
In the skb_cloned case it is not being cleared and
may cause the skb to be dropped when the loopback device
pushes it back up the stack.

Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
Acked-by: Eric Dumazet <eric.dumazet@...il.com>
Tested-by: Markus Trippelsdorf <markus@...ppelsdorf.de>
Signed-off-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html