lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Jun 2010 16:14:20 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: hadi@...erus.ca Cc: Tom Hughes <tom@...pton.nu>, netdev@...r.kernel.org, akpm@...ux-foundation.org, "David S. Miller" <davem@...emloft.net>, Stephen Hemminger <shemminger@...tta.com>, Patrick McHardy <kaber@...sh.net>, Tejun Heo <tj@...nel.org>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] Clear IFF_XMIT_DST_RELEASE for teql interfaces Le mercredi 16 juin 2010 à 09:25 -0400, jamal a écrit : > On Wed, 2010-06-16 at 09:24 +0100, Tom Hughes wrote: > > The sch_teql module, which can be used to load balance over a set of > > underlying interfaces, stopped working after 2.6.30 and has been > > broken in all kernels since then for any underlying interface which > > requires the addition of link level headers. > > > > The problem is that the transmit routine relies on being able to > > access the destination address in the skb in order to do address > > resolution once it has decided which underlying interface it is going > > to transmit through. > > > > In 2.6.31 the IFF_XMIT_DST_RELEASE flag was introduced, and set by > > default for all interfaces, which causes the destination address to be > > released before the transmit routine for the interface is called. > > > > The solution is to clear that flag for teql interfaces. > > > > Signed-off-by: Tom Hughes <tom@...pton.nu> > > Sounds reasonable. Lets CC Eric and get his ACK. > > cheers, > jamal > Sure, I already Acked in on a previous message 5 days ago (although not a formal patch, Stephen forwarded a bugzilla entry) http://permalink.gmane.org/gmane.linux.network/163688 Please David, could you add bugzilla entry in commit ? https://bugzilla.kernel.org/show_bug.cgi?id=16183 Acked-by: Eric Dumazet <eric.dumazet@...il.com> Thanks ! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists