netdev - Re: [PATCH v2 net-next-2.6] syncookies: check decoded options against sysctl settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100616.144228.246524500.davem@davemloft.net>
Date:	Wed, 16 Jun 2010 14:42:28 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fw@...len.de
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next-2.6] syncookies: check decoded options
 against sysctl settings

From: Florian Westphal <fw@...len.de>
Date: Wed, 16 Jun 2010 23:15:49 +0200

> Discard the ACK if we find options that do not match current sysctl
> settings.
> 
> Previously it was possible to create a connection with sack,
> wscale, etc. enabled even if the feature was disabled via sysctl.
> 
> Also remove an unneeded call to tcp_sack_reset() in
> cookie_check_timestamp:
> Both call sites (cookie_v4_check, cookie_v6_check) zero
> "struct tcp_options_received", hand it to tcp_parse_options()
> (which does not change tcp_opt->num_sacks/dsack) and then call
> cookie_check_timestamp().
> 
> Even if num_sacks/dsacks were changed, the structure is allocated on
> the stack and after cookie_check_timestamp returns only a few selected
> members are copied to the inet_request_sock.
> 
> Signed-off-by: Florian Westphal <fw@...len.de>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html