netdev - Re: bnx2 fails to compile on parisc because of missing get_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100617234520S.fujita.tomonori@lab.ntt.co.jp>
Date:	Thu, 17 Jun 2010 23:50:35 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	davem@...emloft.net
Cc:	fujita.tomonori@....ntt.co.jp, mchan@...adcom.com,
	lethal@...ux-sh.org, vapier@...too.org, JBottomley@...ell.com,
	netdev@...r.kernel.org, linux-parisc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: bnx2 fails to compile on parisc because of missing
 get_dma_ops()

On Thu, 17 Jun 2010 07:36:53 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:

> From: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
> Date: Thu, 17 Jun 2010 21:21:13 +0900
> 
> > On Wed, 16 Jun 2010 23:24:44 -0700
> > "Michael Chan" <mchan@...adcom.com> wrote:
> > 
> >> David, why is dma_is_consistent() always returning 1 on sparc?  The
> >> streaming DMA is not consistent.
> > 
> > I think that there are some confusion about dma_is_consistent(). Some
> > architectures think that dma_is_consistent() is supposed to return 1
> > if they can allocate coherent memory (note that some architectures
> > can't allocate coherent memory).
> 
> Right, and that's why it's defined this way.
> 
> If the desired meaning is different, just me know and I'll fix the
> sparc definition.

I think that there are some other architectures do the same. We need
to make sure that all the architectures define dma_is_consistent() in
the same meaning if drivers need it. However, I'm not sure we really
need dma_is_consistent(). There is only one user of it (and I think we
could remove it).

In the bnx2 case, we can simply prefetch on all the archs (or just
remove the optimization).
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html