[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AANLkTik2Rait7ugcDt36ncwqdO-fZrr9iM8usecAyBAC@mail.gmail.com>
Date: Sun, 20 Jun 2010 00:32:20 -0700
From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To: David Miller <davem@...emloft.net>
Cc: netdev@...r.kernel.org, gospo@...hat.com, bphilips@...ell.com,
bruce.w.allan@...el.com
Subject: Re: [net-next-2.6 PATCH 1/8] e1000e: cleanup ethtool loopback setup
code
On Fri, Jun 18, 2010 at 22:15, David Miller <davem@...emloft.net> wrote:
>
> I've applied this series however:
>
> 1) Please address Ben's concerns about turning EEE on by default
> given that standardization is not complete yet.
>
> 2) I hate module parameters, I'd rather you create a new ethtool
> feature bit and thus allow the setting to be modified at run
> time. Please create a new ethtool control flag, and remove
> this module option.
>
> Thanks.
> --
Thank you Dave. I know that Bruce (and company) are actively looking
into your first point. I would think that he would have either a
response or update on the status come Monday/Tuesday.
Regarding option 2, understood and I will work out with Bruce on when
and who will do the work. I will be taking a look at it tomorrow
(later today), if I am not able to come up with a patch in the near
future. I will return to working on it by Wednesday.
--
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists