netdev - Re: [v3 Patch 2/2] mlx4: add dynamic LRO disable support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C1ECD04.20609@redhat.com>
Date:	Mon, 21 Jun 2010 10:23:00 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Stanislaw Gruszka <sgruszka@...hat.com>
CC:	netdev@...r.kernel.org, nhorman@...hat.com, herbert.xu@...hat.com,
	bhutchings@...arflare.com, Ramkrishna.Vepa@...r.com,
	davem@...emloft.net
Subject: Re: [v3 Patch 2/2] mlx4: add dynamic LRO disable support

On 06/18/10 19:09, Stanislaw Gruszka wrote:
> On Fri, Jun 18, 2010 at 06:55:38AM -0400, Amerigo Wang wrote:
>> +static int mlx4_ethtool_op_set_flags(struct net_device *dev, u32 data)
>> +{
>> +	struct mlx4_en_priv *priv = netdev_priv(dev);
>> +	struct mlx4_en_dev *mdev = priv->mdev;
>> +	int rc = 0;
>> +	int changed = 0;
>> +
>> +	if (data&  (ETH_FLAG_NTUPLE | ETH_FLAG_RXHASH))
>> +		return -EOPNOTSUPP;
>> +
>> +	if (data&  ETH_FLAG_LRO) {
>> +		if (!(dev->features&  NETIF_F_LRO))
>> +			changed = 1;
>> +	} else if (dev->features&  NETIF_F_LRO) {
>> +		changed = 1;
>> +		mdev->profile.num_lro = 0;
>
> Everything fine except that, what for you zero num_lro value?
>
> If we set it to zero it will stay zero and we will not create
> proper number of lro descriptors in mlx4_en_create_rx_ring()
> (called from mlx4_en_set_ringparam() ->   mlx4_en_alloc_resources())
> when someone enable LRO again on.
>

Huh? Isn't ->num_lro which controls LRO of mlx4 driver?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html