netdev - Re: PATCH: uninitialized memory access in tcp_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1277147446.9469.67.camel@localhost.localdomain>
Date:	Mon, 21 Jun 2010 21:10:46 +0200
From:	Mathieu Lacage <mathieu.lacage@...hia.inria.fr>
To:	Mitchell Erblich <erblichs@...thlink.net>
Cc:	netdev@...r.kernel.org
Subject: Re: PATCH: uninitialized memory access in tcp_parse_options

On Mon, 2010-06-21 at 11:02 -0700, Mitchell Erblich wrote:

> 		The standard default for TCP with IPv4 is 536, which
> 		translates to 576 MTU.
> 
> 		Thus, why don't you init mss to 536?

I don't know: I am not a tcp expert and I am not sure I really
understand the way this function is expected to be used by callers but I
sent a patch to make sure that someone would feel compelled to find the
right fix. It looks like callers of this function are expected to
initialize the fields themselves so, the idea of doing the
initialization in tcp_parse_options is probably bad.

Mathieu
-- 
Mathieu Lacage <mathieu.lacage@...hia.inria.fr>
Tel: +33 4 9238 5056

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html