lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20100621.135509.260072870.davem@davemloft.net> Date: Mon, 21 Jun 2010 13:55:09 -0700 (PDT) From: David Miller <davem@...emloft.net> To: herbert@...dor.apana.org.au Cc: jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org, gospo@...hat.com, bphilips@...ell.com, john.r.fastabend@...el.com Subject: Re: [net-next-2.6 PATCH] net: consolidate netif_needs_gso() checks From: Herbert Xu <herbert@...dor.apana.org.au> Date: Thu, 17 Jun 2010 20:18:57 +1000 > On Wed, Jun 16, 2010 at 05:18:12PM -0700, Jeff Kirsher wrote: >> From: John Fastabend <john.r.fastabend@...el.com> >> >> netif_needs_gso() is checked twice in the TX path once, >> before submitting the skb to the qdisc and once after >> it is dequeued from the qdisc just before calling >> ndo_hard_start(). This opens a window for a user to >> change the gso/tso or tx checksum settings that can >> cause netif_needs_gso to be true in one check and false >> in the other. >> >> Specifically, changing TX checksum setting may cause >> the warning in skb_gso_segment() to be triggered if >> the checksum is calculated earlier. >> >> This consolidates the netif_needs_gso() calls so that >> the stack only checks if gso is needed in >> dev_hard_start_xmit(). >> >> Signed-off-by: John Fastabend <john.r.fastabend@...el.com> >> Cc: Herbert Xu <herbert@...dor.apana.org.au> >> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com> > > Acked-by: Herbert Xu <herbert@...dor.apana.org.au> Applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists