netdev - Re: [PATCH 0/3] b43: logging cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C24AEE4.4090700@bu3sch.de>
Date:	Fri, 25 Jun 2010 15:28:04 +0200
From:	Michael Büsch <mb@...sch.de>
To:	Joe Perches <joe@...ches.com>
CC:	"John W. Linville" <linville@...driver.com>,
	Stefano Brivio <stefano.brivio@...imi.it>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Larry.Finger@...inger.net,
	zajec5@...il.com
Subject: Re: [PATCH 0/3] b43: logging cleanups

On 06/24/2010 09:40 PM, Joe Perches wrote:
> On Thu, 2010-06-24 at 14:53 -0400, John W. Linville wrote:
>> On Sat, Jun 19, 2010 at 04:30:08PM -0700, Joe Perches wrote:
>>> Just some small cleanups
>>> Joe Perches (3):
>>>    drivers/net/wireless/b43: Use local ratelimit_state
>>>    drivers/net/wireless/b43: Logging cleanups
>>>    drivers/net/wireless/b43: Rename b43_debug to b43_debugging
>> Any of the b43 guys want to express an opinion on these?

The cleanups, well, exchange one name for the other. I don't have a
strong opinion on one or the other. So in the end I don't see why
that stuff should be renamed. However, in the end I really do not care.

I'm not sure why we need an additional ratelimit here. Is it a policy
that every kernel driver should have local ratelimiting? If not, why
do you think b43 needs its own ratelimiting? Note that b43 does not
output a single line to dmesg in normal operation, after init has
finished (and ratelimit is disabled in init).

> Stefano, are you active here?
> Your last ack for b43 was Feb 2008.
> There have been 400+ commits to b43 without your ack.
>
> Should your name be moved from MAINTAINERS to CREDITS?
>
> $ ./scripts/get_maintainer.pl --rolestats -f drivers/net/wireless/b43/
> Stefano Brivio<stefano.brivio@...imi.it>  (maintainer:B43 WIRELESS DRIVER)
> "John W. Linville"<linville@...driver.com>  (maintainer:NETWORKING [WIREL...,commit_signer:204/240=85%)
> "Rafał Miłecki"<zajec5@...il.com>  (commit_signer:83/240=35%)
> "Gábor Stefanik"<netrolller.3d@...il.com>  (commit_signer:44/240=18%)
> Michael Buesch<mb@...sch.de>  (commit_signer:39/240=16%)
> Larry Finger<Larry.Finger@...inger.net>  (commit_signer:13/240=5%)
> linux-wireless@...r.kernel.org (open list:B43 WIRELESS DRIVER)
> netdev@...r.kernel.org (open list:NETWORKING DRIVERS)
> linux-kernel@...r.kernel.org (open list)

I think these statistics are almost worthless for b43.

-- 
Greetings Michael.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html