netdev - Re: [PATCH v2] caif-driver: Add CAIF-SPI Protocol driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100625.211223.232914661.davem@davemloft.net>
Date:	Fri, 25 Jun 2010 21:12:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sjur.brandeland@...ricsson.com
Cc:	sjurbr@...il.com, netdev@...r.kernel.org, marcel@...tmann.org,
	daniel.martensson@...ricsson.com, linus.walleij@...ricsson.com
Subject: Re: [PATCH v2] caif-driver: Add CAIF-SPI Protocol driver.

From: sjur.brandeland@...ricsson.com
Date: Mon, 21 Jun 2010 23:58:04 +0200

> David Miller wrote:
>>You should never set CONFIG_* defines from the Makefile
>>commands, always set them in your Kconfig statements.
> 
> Changes from last version: Removed CONFIG_* defines from Makefile.

Surrounding a config options with "if XXX" protection is not the
proper way to protect config options.  Simply add a proper "Depends"
specification to it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html