netdev - Re: [PATCH] net, ucc_geth: ethtool -d shows phy register values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20100626.212033.135523015.davem@davemloft.net>
Date:	Sat, 26 Jun 2010 21:20:33 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	holger.brunck@...mile.com
Cc:	netdev@...r.kernel.org, christopher.varlese@...mile.com,
	leoli@...escale.com, avorontsov@...mvista.com, tj@...nel.org
Subject: Re: [PATCH] net, ucc_geth: ethtool -d shows phy register values

From: Holger Brunck <holger.brunck@...mile.com>
Date: Tue, 15 Jun 2010 16:03:23 +0200

> From: Chris Varlese <christopher.varlese@...mile.com>
> 
> Fixes MPC83xx UCC Ethernet driver so ethtool -d dumps values of
> the PHY registers (like other devices do) instead of the UCC registers
> of the MPC83xx.
> 
> Signed-off-by: Chris Varlese <christopher.varlese@...mile.com>
> Signed-off-by: Holger Brunck <holger.brunck@...mile.com>

This doesn't look right at all.

ethtool -d dumps "chip registers", not the PHY registers.  So the
current code looks correct, not what you're changing it to.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html