lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 28 Jun 2010 15:18:44 +0100
From:	Ben Hutchings <>
To:	Stanislaw Gruszka <>
Cc:	Amit Salecha <>,
	"" <>,
	Amerigo Wang <>,
	Anirban Chakraborty <>
Subject: Re: [PATCH -next] qlcnic: fail when try to setup unsupported

On Mon, 2010-06-28 at 16:14 +0200, Stanislaw Gruszka wrote:
> My plan is something like that:
> static const struct ethtool_ops my_ethtool_ops = {
>         .get_flags              = ethtool_op_get_flags,
>         .set_flags              = ethtool_op_set_flags,
> 	.supported_flags	= ETH_FLAG_LRO
> }
> Plus op->supported_flags check in ethtool_op_set_flags. That will allow
> to define flags per driver. There is also possible to add supported_flags
> to netdev, but I would like to avoid that - in such case drivers can use
> custom .set_flags function.

Sounds good to me.


Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists