netdev - Re: [PATCH linux-2.6.35-rc3] micrel phy driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1277753027.2089.22.camel@achroite.uk.solarflarecom.com>
Date:	Mon, 28 Jun 2010 20:23:47 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	"Choi, David" <David.Choi@...rel.Com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH linux-2.6.35-rc3] micrel phy driver

On Mon, 2010-06-28 at 11:51 -0700, Choi, David wrote:
[...]
> @@ -106,8 +233,12 @@ MODULE_LICENSE("GPL");
>  
>  static struct mdio_device_id micrel_tbl[] = {
>  	{ PHY_ID_KSZ9021, 0x000fff10 },
> -	{ PHY_ID_VSC8201, 0x00fffff0 },
>  	{ PHY_ID_KS8001, 0x00fffff0 },
> +	{ PHY_ID_KSZ9021, 0x000fff10 },
> +	{ PHY_ID_KS8001, 0x00fffff0 },
> +	{ PHY_ID_KS8737, 0x00fffff0 },
> +	{ PHY_ID_KS8041, 0x00fffff0 },
> +	{ PHY_ID_KS8051, 0x00fffff0 },
>  	{ }
>  };

You're duplicating the device IDs for KSZ9021 and KS8001.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html