netdev - Re: [PATCH -next] ixgbe: use NETIF_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTikI4sf7Z0nwNoknk-BF3j9iBMUrQhWuT9O6iBLV@mail.gmail.com>
Date:	Tue, 29 Jun 2010 11:00:09 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Stanislaw Gruszka <sgruszka@...hat.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH -next] ixgbe: use NETIF_F_LRO

On Tue, Jun 29, 2010 at 07:38, Stanislaw Gruszka <sgruszka@...hat.com> wrote:
> Both ETH_FLAG_LRO and NETIF_F_LRO have the same value, but NETIF_F_LRO
> is intended to use with netdev->features.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@...hat.com>
> ---
>  drivers/net/ixgbe/ixgbe_ethtool.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethtool.c b/drivers/net/ixgbe/ixgbe_ethtool.c
> index 873b45e..e2ab4ae 100644
> --- a/drivers/net/ixgbe/ixgbe_ethtool.c
> +++ b/drivers/net/ixgbe/ixgbe_ethtool.c
> @@ -2227,7 +2227,7 @@ static int ixgbe_set_flags(struct net_device *netdev, u32 data)
>                                break;
>                        }
>                } else if (!adapter->rx_itr_setting) {
> -                       netdev->features &= ~ETH_FLAG_LRO;
> +                       netdev->features &= ~NETIF_F_LRO;
>                        if (data & ETH_FLAG_LRO)
>                                e_info("rx-usecs set to 0, "
>                                        "LRO/RSC cannot be enabled.\n");
> --

Thanks, I have added it to my queue of patches.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html