netdev - Re: [PATCH v4 2/2] caif-driver: Add CAIF-SPI Protocol driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100629.001020.58427550.davem@davemloft.net>
Date:	Tue, 29 Jun 2010 00:10:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sjur.brandeland@...ricsson.com
Cc:	sjurbr@...il.com, netdev@...r.kernel.org, marcel@...tmann.org,
	daniel.martensson@...ricsson.com, linus.walleij@...ricsson.com
Subject: Re: [PATCH v4 2/2] caif-driver: Add CAIF-SPI Protocol driver.

From: sjur.brandeland@...ricsson.com
Date: Sat, 26 Jun 2010 23:31:29 +0200

> From: Sjur Braendeland <sjur.brandeland@...ricsson.com>
> 
> This patch introduces the CAIF SPI Protocol Driver for
> CAIF Link Layer.
> 
> This driver implements a platform driver to accommodate for a
> platform specific SPI device. A general platform driver is not
> possible as there are no SPI Slave side Kernel API defined.
> A sample CAIF SPI Platform device can be found in
> .../Documentation/networking/caif/spi_porting.txt
> 
> Signed-off-by: Sjur Braendeland <sjur.brandeland@...ricsson.com>

Applied, but:

> +
> +config CAIF_SPI_SYNC
> +	bool "Next command and length in start of frame"
> +	depends on CAIF_SPI_SLAVE
> +	default n
> +	---help---
> +	Putting the next command and length in the start of the frame can
> +	help to synchronize to the next transfer in case of over or under-runs.
> +	This option also needs to be enabled on the modem.
> +

This adds an extra new-line at the end of the file, which I corrected
when applying this.

GIT warns when trying to apply a patch with this problem,
checkpatch.pl probably does too, so you really can (in an automated
way) prevent these things from showing up in your submission.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html