netdev - Re: [RFC net-2.6 PATCH] ixgbe: need to purge skb qdisc lists when changing real_num_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100628.211930.102546288.davem@davemloft.net>
Date:	Mon, 28 Jun 2010 21:19:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	john.r.fastabend@...el.com
Cc:	netdev@...r.kernel.org, jeffrey.t.kirsher@...el.com
Subject: Re: [RFC net-2.6 PATCH] ixgbe: need to purge skb qdisc lists when
 changing real_num_tx_queues

From: John Fastabend <john.r.fastabend@...el.com>
Date: Sun, 20 Jun 2010 22:25:20 -0700

> This patch exports dev_deactivate() symbol.
> 
> The qdisc needs to be purged when real_num_tx_queues is
> changed so that skbs do not hit ndo_start_xmit with
> queue_mappings corresponding to tx_rings already freed.
> 
> real_num_tx_queues is changed when dynamically enabling or
> disabling DCB or FCoE.  To purge the qdisc use dev_deactivate().
> 
> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>

Whatever it is that needs to happen when real_num_tx_queues changes
outght to be transparent to drivers.

Therefore we should hide all of these details behind a well named
interface drivers can call when they need to change real_num_tx_queues.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html