netdev - Re: [PATCH] bonding: check if clients MAC addr has changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100629155824.GB13444@redhat.com>
Date:	Tue, 29 Jun 2010 12:58:24 -0300
From:	Flavio Leitner <fleitner@...hat.com>
To:	Brian Haley <brian.haley@...com>
Cc:	bonding-devel@...ts.sourceforge.net,
	Jay Vosburgh <fubar@...ibm.com>, netdev@...r.kernel.org,
	Andy Gospodarek <gospo@...hat.com>
Subject: Re: [PATCH] bonding: check if clients MAC addr has changed

On Tue, Jun 29, 2010 at 11:39:12AM -0400, Brian Haley wrote:
> On 06/29/2010 10:41 AM, Flavio Leitner wrote:
> > diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
> > index 40fdc41..67154bb 100644
> > --- a/drivers/net/bonding/bond_alb.c
> > +++ b/drivers/net/bonding/bond_alb.c
> > @@ -340,7 +340,8 @@ static void rlb_update_entry_from_arp(struct bonding *bond, struct arp_pkt *arp)
> >  
> >  	if ((client_info->assigned) &&
> >  	    (client_info->ip_src == arp->ip_dst) &&
> > -	    (client_info->ip_dst == arp->ip_src)) {
> > +	    (client_info->ip_dst == arp->ip_src) &&
> > +	    (memcmp(client_info->mac_dst, arp->mac_src, ETH_ALEN))) {
> >  		/* update the clients MAC address */
> >  		memcpy(client_info->mac_dst, arp->mac_src, ETH_ALEN);
> >  		client_info->ntt = 1;
> 
> compare_ether_addr_64bits() ?

yeah, sounds better. Bonding driver is using it already in
many other places.

-- 
Flavio
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html