netdev - Re: [PATCH] vlan_dev: VLAN 0 should be treated as "no vlan tag" (802.1p packet)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100630.131616.233403329.davem@davemloft.net>
Date:	Wed, 30 Jun 2010 13:16:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	pedro.netdev@...devamos.com
Cc:	netdev@...r.kernel.org, kaber@...sh.net, bhutchings@...arflare.com,
	eric.dumazet@...il.com
Subject: Re: [PATCH] vlan_dev: VLAN 0 should be treated as "no vlan tag"
 (802.1p packet)

From: Pedro Garcia <pedro.netdev@...devamos.com>
Date: Mon, 28 Jun 2010 01:21:19 +0200

> Last version of the patch. Now I think it is OK, of course pending 
> Eric's signed-off-by for the accel HW part.

Eric, please review.

> 
> If this is too long for a changelog, tell me and I will try to sum it
> up:

To me, not commit message is too long, the more the better. :)

> +       if ((event == NETDEV_UP) &&
> +           (dev->features & NETIF_F_HW_VLAN_FILTER) &&
> +           (dev->netdev_ops->ndo_vlan_rx_add_vid)) {

There is no reason to surround this final NULL pointer check with
parenthesis, it just makes reading it confusing.
> +       if (vlan_dev)
> +               skb->dev = vlan_dev;
> +       else
> +               if (vlan_id)
> +                       goto drop;

Please format this as:

	if (a)
		b;
	else if (c)
		d;


> +       if (vlan_dev)
> +               skb->dev = vlan_dev;
> +       else
> +               if (vlan_id)
> +                       goto drop;

Same here.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html