netdev - Re: [PATCH] Fix b44 RX FIFO overflow recovery.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100630.132553.163237479.davem@davemloft.net>
Date:	Wed, 30 Jun 2010 13:25:53 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	james.dutton@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] Fix b44 RX FIFO overflow recovery.

From: James Courtier-Dutton <james.dutton@...il.com>
Date: Wed, 30 Jun 2010 21:11:18 +0100

> diff --git a/drivers/net/b44.c b/drivers/net/b44.c
> index 69d9f3d..72537c1 100644
> --- a/drivers/net/b44.c
> +++ b/drivers/net/b44.c
> @@ -852,12 +852,46 @@ static int b44_poll(struct napi_struct *napi, int budget)
>  		/* spin_unlock(&bp->tx_lock); */
>  	}
>  	spin_unlock_irqrestore(&bp->lock, flags);
> +	if (bp->istat & ISTAT_DSCE)
> +	{
> +		printk(KERN_INFO "b44_poll: ISTAT_DSCE\n");
> +	}

Using braces here is overkill, and even if it was appropriate it's formatted
incorrectly, it should be:

	if (x)
		y;

for single-line code blocks, and:

	if (x) {
		y;
		z;
	}

For multi-line code blocks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html