netdev - Re: [PATCH 0/2] cxgb4vf: small fixes to new driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Jun 2010 14:05:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	leedom@...lsio.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 0/2] cxgb4vf: small fixes to new driver

I've applied both patches but you really need to fix up how you
submit these changes.

1) Your Subject: line becomes the commit message header.

   It should be a single statement, prefixed by "xxx: "
   where "xxx" is the subsystem or driver you are making
   changes to.  Here it would be "cxgb4vf: "

   It should not bleed into the rest of commit message body, like
   your's did.

2) You should not include all of the commit crap from GIT in the body
   of your email.  I just have to edit all of that junk out before I
   apply your patch.

A perfect email patch submission looks like this (my comments are in
{} braces):

From: Me <me@...rever.com>
Subject: [PATCH N/M] subsystem: Make whatever do whatever.

{ Next line is optional, it goes into your email body and is used
  when the patch author is someone other than the person sending
  the email }

From: Real Author <cooldude@...rever.com>

This explains what this commit message is doing.

It gives code path traces, pretty ascii-art diagrams, and cross
references when doing so helps other people understand the change.

Signed-off-by: Real Author <cooldude@...rever.com>
Signed-off-by: Me <me@...rever.com>

{ "---" marks the end of the commit message text, afterwards you
   can add whatever auxiliary information you want people to know about
   the patch, but for whatever reason it'snt appropriate for the
   commit message. }

---

This is some extra information I want the list to see when I post
this patch.

{ And finally the full patch comes next. }

Ok?  All of the GIT tools know exactly how to pick apart the above
formatted patch and apply it to the tree with the author, etc. all
set properly.

And this is the format output by "git send-email" so you can use it
to help construct proper patch postings even if you don't want to
use "git send-email" to send the email directly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html